Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make command.build_ext.get_ext_filename typesafe #4592

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Aug 24, 2024

Summary of changes

Extracted from #4192 . Fixes mypy and pyright errors when get_ext_filename is annotated

Pull Request Checklist

@Avasam Avasam force-pushed the Make-get_ext_filename-typesafe branch from c1c6c02 to 1671425 Compare August 24, 2024 18:46
@abravalheri abravalheri merged commit 9aec16b into pypa:main Aug 27, 2024
18 of 21 checks passed
@abravalheri
Copy link
Contributor

Thank you very much!

@Avasam Avasam deleted the Make-get_ext_filename-typesafe branch August 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants