Made setuptools.package_index.Credential a NamedTuple
#4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
package_index.Credential-NamedTuple
branch
from
11ef30f to
091de43
Compare
Avasam
force-pushed
the
package_index.Credential-NamedTuple
branch
from
091de43 to
2f77203
Compare
Avasam
commented
Aug 20, 2024
| def __str__(self): | ||
| return '%(username)s:%(password)s' % vars(self) | ||
| def __str__(self) -> str: | ||
| return f'{self.username}:{self.password}' |
There was a problem hiding this comment.
I considered return ":".join(self) but felt explicit was better.
Avasam
commented
Aug 20, 2024
| def __init__(self, username, password): | ||
| self.username = username | ||
| self.password = password | ||
| Displayed separated by `:`. |
There was a problem hiding this comment.
Unsure if this line is redundant
Suggested change
| Displayed separated by `:`. |
|
I like this one. We can revert if we find problems in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Docstring said "like a namedtuple", but I don't see why it can't be simplified to a
NamedTupleContributes to #2345 and my batches of dunder typing (this was the only untyped
__iter__outside tests)One potential difference is the repr:
'<setuptools.package_index.Credential object at 0x000001D0C827AD90>'Credential(username='a', password='b')(but
__str__already printed the values)Pull Request Checklist
newsfragments/.(See documentation for details)