Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Work towards #2345
Reduce changes in #4192 and #4504
I typed all
__enter__
and__exit__
(didn't find any__aenter__
or__aexit__
)Note here that
object
param type stands for "Unused even in subclass" andobject
return type in a protocol stands for "callable return value unused/unchecked". I can use_typeshed.Unused
instead if that's clearer.Pull Request Checklist
newsfragments/
. (not public facing yet)(See documentation for details)