Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt setuptools_scm #4532

Open
wants to merge 3 commits into
base: feature/remove-self-tags
Choose a base branch
from

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 31, 2024

  • Replace static version with setuptools-scm version.
  • Remove bumpversion and rely on jaraco.develop for finalize operation.
  • Vendor setuptools_scm instead of declaring it to avoid bootstrapping issue.

Summary of changes

Closes #4530

Pull Request Checklist

@jaraco jaraco force-pushed the feature/remove-self-tags branch from c45e774 to 5782e2a Compare July 31, 2024 18:44
@jaraco jaraco force-pushed the feature/adopt-setuptools-scm branch from 1b8a693 to 2faa82c Compare July 31, 2024 18:46
@jaraco
Copy link
Member Author

jaraco commented Jul 31, 2024

I don't understand the test failures. The tests pass for me locally. Also, the test failures seem largely unrelated to the change. The only thing I can think is that maybe the tests are somehow reliant on Setuptools' own MANIFEST.in. I'm going to sleep on it and tomorrow try to replicate the issue in a Docker image or using the act tool.

_repair_changelog()


def _repair_changelog():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does excluding this file also mean that we no longer need to repair the changelog and that #2666 is already solved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe so. I don't encounter the issue in other skeleton projects, so I assume so. If it turns out it's still a problem, I'll just strip out whatever customizations setuptools is using that introduce the bug. No reason to carry around this debt.

@@ -122,6 +122,8 @@ core = [
"platformdirs >= 2.6.2",
]

[tool.setuptools_scm]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this line gets moved, but it was already present. I'll move it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants