Adopted the bdist_wheel command from "wheel"

[agronholm]

Summary of changes

This adopts the bdist_wheel command and vendors most of the wheel code.

Closes #1386.

Pull Request Checklist

• Changes have tests
• News fragment added in newsfragments/.
  (See documentation for details)

NOTE: Coverage reports missing lines in test_bdist_wheel but those would be handled with combined coverage reporting.

[agronholm]

@jaraco I'll need some assistance, perhaps during the sprints, to figure out why there are so many errors/failures. The test suite didn't pass for me locally even with a pristine copy of the repo without my changes, but these changes seemed to have introduced tons of additional errors and failures.

[abravalheri]

I'll need some assistance, perhaps during the sprints, to figure out why there are so many errors/failures. The test suite didn't pass for me locally even with a pristine copy of the repo without my changes, but these changes seemed to have introduced tons of additional errors and failures.

Just a wild guess, but maybe it also needs to be bootstrapped in https://github.com/pypa/setuptools/blob/main/bootstrap.egg-info/entry_points.txt?

[agronholm]

I'll need some assistance, perhaps during the sprints, to figure out why there are so many errors/failures. The test suite didn't pass for me locally even with a pristine copy of the repo without my changes, but these changes seemed to have introduced tons of additional errors and failures.

Just a wild guess, but maybe it also needs to be bootstrapped in https://github.com/pypa/setuptools/blob/main/bootstrap.egg-info/entry_points.txt?

I have no clue. Can you make sense of the errors in CI? It's like at least some of them have nothing to do with this change.

[abravalheri]

Can you make sense of the errors in CI? It's like at least some of them have nothing to do with this change.

For some reason when you run tox -e vendor some directories ended up excluded. I am not sure why that happened, but when I run tox -e vendor in my machine, as a result it creates these new files that are not added to the PR yet:

# Python 3.12 (pipx run --python python3.12 tox -e vendor)
        new file:   pkg_resources/_vendor/backports/tarfile/__init__.py
        new file:   pkg_resources/_vendor/backports/tarfile/__main__.py
        new file:   pkg_resources/_vendor/backports/tarfile/compat/__init__.py
        new file:   pkg_resources/_vendor/backports/tarfile/compat/py38.py
        new file:   setuptools/_vendor/backports/tarfile/__init__.py
        new file:   setuptools/_vendor/backports/tarfile/__main__.py
        new file:   setuptools/_vendor/backports/tarfile/compat/__init__.py
        new file:   setuptools/_vendor/backports/tarfile/compat/py38.py

# Python 3.8 (pipx run --python python3.8 tox -e vendor)
        new file:   pkg_resources/_vendor/backports/tarfile/__init__.py
        new file:   pkg_resources/_vendor/backports/tarfile/__main__.py
        new file:   pkg_resources/_vendor/backports/tarfile/compat/__init__.py
        new file:   pkg_resources/_vendor/backports/tarfile/compat/py38.py
        new file:   setuptools/_vendor/backports/tarfile/__init__.py
        new file:   setuptools/_vendor/backports/tarfile/__main__.py
        new file:   setuptools/_vendor/backports/tarfile/compat/__init__.py
        new file:   setuptools/_vendor/backports/tarfile/compat/py38.py

I think these files need to be included.

There also seems to be a problems with static check:

.tox/py/lib/python3.12/site-packages/pytest_mypy.py:212: MypyWarning
_________________________________ setuptools/tests/test_bdist_wheel.py _________________________________
[gw4] linux -- Python 3.12.3 /home/abravalheri/workspace/setuptools/.tox/py/bin/python
458: error: Cannot find implementation or library stub for module named "wheel"  [import-not-found]
458: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

Maybe this solves the problem:

diff --git i/setuptools/tests/test_bdist_wheel.py w/setuptools/tests/test_bdist_wheel.py
index 161fb88e2..1f8e76e30 100644
--- i/setuptools/tests/test_bdist_wheel.py
+++ w/setuptools/tests/test_bdist_wheel.py
@@ -455,6 +455,6 @@ def test_no_ctypes(monkeypatch) -> None:
         if module.startswith("wheel"):
             monkeypatch.delitem(sys.modules, module)

-    from wheel import bdist_wheel
+    from setuptools.command import bdist_wheel

     assert bdist_wheel

I am still having a look on the other errors that appeared.

[agronholm]

Should be a-ok now. The missing coverage lines reported by collateral/diffcov are due to conditional imports and would be covered by a combined coverage report.

[agronholm]

Adapted to changes in main, all good again.

[jaraco]

Thanks Alex for the work here. I've added @agronholm as a Setuptools Developer. Please feel free to merge.

[agronholm]

A bit late to the game? This was merged 3 months ago.