Adequate venv fixtures to the latest change in virtualenv for Python 3.12 #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version v20.23.0, `virtualenv` will no longer include `wheel` and `setuptools` in the created folders. Some tests in the setuptools test suite assume that these packages are always present. So we need to adequate these tests.
|
It also seems that somehow I added a commit to correct that. |
abravalheri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Since version v20.23.0,
virtualenvwill no longer includewheelandsetuptoolsin the created folders.Some tests in the setuptools test suite assume that these packages are always present. So we need to adequate these tests.
EDIT: Apparently we are also having problems with
__version__. It seems that the code path triggered in the "unhappy path" that results in__version__ = "unknown".Since
unknownis not a valid PEP 440, it causes problem. I changed this fallback to be PEP 440-compliant.This problem might be related to the race conditions between
importlib.metadata(used by pytest and plugins) andegg_info(that writessetuptools.egg-info/PKG-INFO).Closes
Pull Request Checklist
changelog.d/.(See documentation for details)