Add unit test for issue with attr:
#3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this situation is different from the one described in pypa#3000, that issue served as inspiration behind this change.
abravalheri
force-pushed
the
test-open-issues
branch
from
7fb9736 to
d489141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
attr:can be solved via static import even when other imports happen first ([BUG] __version__ must be imported first to be used as attr #3176)cmdclasscan be loaded from within the given package, (this is not exactly [BUG] ModuleNotFoundError when using cmdclass option in PEP517-style build #3000, but similar).Closes #3176
Pull Request Checklist
changelog.d/.(See documentation for details)