sdist: Accept -u/--owner and -g/--group options #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarshall
force-pushed
the
feature/sdist-owner-group
branch
from
d30634e to
a5c7803
Compare
Controlling the file ownership recorded in tar archives is useful for those striving towards reproducible builds. These options are already understood by distutils.command.sdist.sdist, so just need to be accepted by setuptools.command.sdist.sdist to be propagated. Fixes pypa#1893.
jmarshall
force-pushed
the
feature/sdist-owner-group
branch
from
a5c7803 to
576dece
Compare
|
Doing some more investigation, I see that this support was added to distutils in Python 2.7 and slated for Python 3.2, but rolled back (see 5f1980b and bpo-6516 and bpo-19544). I wish I understood what factors led to the omission of other options from distutils. It looks like the masking of distutils options was intentional in f3694a0. Ideally, reproducible builds should be possible without supplying non-default options, but for now, this approach is the least invasive and should ease the merge with distutils. |
jmarshall
added a commit
to jmarshall/pysam
that referenced
this pull request
Sep 28, 2021
Use --owner/--group to canonicalise the file ownership within the sdist tarball. The job runs as runner/docker, which is meaningless outside GH Actions' infrastructure. Work around setuptools <= v58.1.0 which does not provide these options in its (main) sdist command. This can be removed once pypa/setuptools#2800 appears in a release and has been deployed on Actions runners.
copybara-service bot
pushed a commit
to tink-crypto/tink-py
that referenced
this pull request
Jul 5, 2022
- Rename `build_linux` as `create_distribution_for_linux` and split it into two functions, one for wheels build and one for source distribution build - Rename `build_macos` as `create_distribution_for_macos`. - Add comments to functions - Remove `set_owner_within_tar` as this is no longer needed: since pypa/setuptools#2800 the parameters `--owner` and `--group` are propagated to setuptools. PiperOrigin-RevId: 459048112 Change-Id: If9f2cbbaf9344d34c5f849bc3984631d1d519321
chuckx
pushed a commit
to tink-crypto/tink
that referenced
this pull request
Jul 12, 2022
- Rename `build_linux` as `create_distribution_for_linux` and split it into two functions, one for wheels build and one for source distribution build - Rename `build_macos` as `create_distribution_for_macos`. - Add comments to functions - Remove `set_owner_within_tar` as this is no longer needed: since pypa/setuptools#2800 the parameters `--owner` and `--group` are propagated to setuptools. PiperOrigin-RevId: 459048112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Controlling the file ownership recorded in tar archives is useful for those striving towards reproducible builds, as discussed in #1893. These options are already understood by
distutils.command.sdist.sdist, so just need to be accepted bysetuptools.command.sdist.sdistto be propagated.I didn't see any tests of the adjacent
sdistoptions such as--keep-tempor--dist-dir, so as the change is to data only and effectively just forwards to already existing distutils code, I haven't added any additional tests. If there is somewhere appropriate to add a new test, please recommend where and I will add something appropriate. A similar comment applies to documentation.Closes #1893.
Pull Request Checklist
changelog.d/.(See documentation for details)