-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_meta_legacy backend #1652
Commits on Feb 3, 2019
-
Wrap build_meta backend in a class
In order to support both the `build_meta` and `build_meta_legacy` backends, the core functionality is wrapped in a class with methods to be overridden in build_meta_legacy. The class is an implementation detail and should remain private.
Configuration menu - View commit details
-
Copy full SHA for 74c323d - Browse repository at this point
Copy the full SHA 74c323dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f40a47a - Browse repository at this point
Copy the full SHA f40a47aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d0daf1 - Browse repository at this point
Copy the full SHA 6d0daf1View commit details -
Add test for relative path imports in build_meta
Failing test adapted from PR pypa#1643 Co-authored-by: Tzu-ping Chung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bd800f4 - Browse repository at this point
Copy the full SHA bd800f4View commit details -
Add failing test suite for build_meta_legacy
This runs all build_meta tests, plus a test that it is possible to import from the directory containing `setup.py` when using the build_meta_legacy backend.
Configuration menu - View commit details
-
Copy full SHA for a114112 - Browse repository at this point
Copy the full SHA a114112View commit details -
This is part of the solution to GH pypa#1642, it is a backwards-compatibility backend that can be used as a default PEP 517 backend for projects that use setuptools but haven't opted in to build_meta.
Configuration menu - View commit details
-
Copy full SHA for fd3b06d - Browse repository at this point
Copy the full SHA fd3b06dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90a8701 - Browse repository at this point
Copy the full SHA 90a8701View commit details -
Set sys.path in try/finally block with comment
Per Nick Coghlan's suggestion on PR pypa#1652, a try/finally block ensures that the path is restored even in the event of an error.
Configuration menu - View commit details
-
Copy full SHA for 49d1772 - Browse repository at this point
Copy the full SHA 49d1772View commit details -
Use absolute path in build_meta_legacy
Using the absolute path to the directory of the setup script better mimics the semantics of a direct invocation of python setup.py.
Configuration menu - View commit details
-
Copy full SHA for db590ba - Browse repository at this point
Copy the full SHA db590baView commit details -
Move build_meta_legacy to build_meta:legacy
Rather than exposing a top-level module for the legacy backend, we will move the legacy backend into the `setuptools.build_meta` module and specify it using the module:object syntax.
Configuration menu - View commit details
-
Copy full SHA for 11fb3f3 - Browse repository at this point
Copy the full SHA 11fb3f3View commit details
Commits on Feb 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e04a41e - Browse repository at this point
Copy the full SHA e04a41eView commit details