Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_meta_legacy backend #1652

Merged
merged 11 commits into from
Feb 5, 2019
Merged

Commits on Feb 3, 2019

  1. Wrap build_meta backend in a class

    In order to support both the `build_meta` and `build_meta_legacy`
    backends, the core functionality is wrapped in a class with methods to
    be overridden in build_meta_legacy. The class is an implementation
    detail and should remain private.
    pganssle committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    74c323d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f40a47a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d0daf1 View commit details
    Browse the repository at this point in the history
  4. Add test for relative path imports in build_meta

    Failing test adapted from PR pypa#1643
    
    Co-authored-by: Tzu-ping Chung <[email protected]>
    pganssle and uranusjr committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    bd800f4 View commit details
    Browse the repository at this point in the history
  5. Add failing test suite for build_meta_legacy

    This runs all build_meta tests, plus a test that it is possible to
    import from the directory containing `setup.py` when using the
    build_meta_legacy backend.
    pganssle committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    a114112 View commit details
    Browse the repository at this point in the history
  6. Add build_meta_legacy backend

    This is part of the solution to GH pypa#1642, it is a
    backwards-compatibility backend that can be used as a default PEP 517
    backend for projects that use setuptools but haven't opted in to
    build_meta.
    pganssle committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    fd3b06d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    90a8701 View commit details
    Browse the repository at this point in the history
  8. Set sys.path in try/finally block with comment

    Per Nick Coghlan's suggestion on PR pypa#1652, a try/finally block ensures
    that the path is restored even in the event of an error.
    pganssle committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    49d1772 View commit details
    Browse the repository at this point in the history
  9. Use absolute path in build_meta_legacy

    Using the absolute path to the directory of the setup script better
    mimics the semantics of a direct invocation of python setup.py.
    pganssle committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    db590ba View commit details
    Browse the repository at this point in the history
  10. Move build_meta_legacy to build_meta:legacy

    Rather than exposing a top-level module for the legacy backend, we will
    move the legacy backend into the `setuptools.build_meta` module and
    specify it using the module:object syntax.
    pganssle committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    11fb3f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Configuration menu
    Copy the full SHA
    e04a41e View commit details
    Browse the repository at this point in the history