Merge pull request #2780 from hugovk/deprecate-bdist_rpm

Deprecate bdist_rpm

.github/workflows/main.yml

@@ -7,10 +7,10 @@ jobs:
     strategy:
       matrix:
         python:
+        - pypy3
         - 3.6
         - 3.9
         - 3.10.0-alpha - 3.10.99
-        - pypy3
         platform: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.platform }}
     steps:

.gitignore

@@ -6,6 +6,7 @@ docs/build
 include
 lib
 distribute.egg-info
+foo.egg-info
 setuptools.egg-info
 .coverage
 .eggs

changelog.d/1988-change.rst

@@ -0,0 +1,2 @@
+Deprecated the ``bdist_rpm`` command. Binary packages should be built as wheels instead.
+-- by :user:`hugovk`

setuptools/command/bdist_rpm.py

@@ -1,4 +1,7 @@
 import distutils.command.bdist_rpm as orig
+import warnings
+
+from setuptools import SetuptoolsDeprecationWarning
 
 
 class bdist_rpm(orig.bdist_rpm):
@@ -11,6 +14,12 @@ class bdist_rpm(orig.bdist_rpm):
     """
 
     def run(self):
+        warnings.warn(
+            "bdist_rpm is deprecated and will be removed in a future "
+            "version. Use bdist_wheel (wheel packages) instead.",
+            SetuptoolsDeprecationWarning,
+        )
+
         # ensure distro name is up-to-date
         self.run_command('egg_info')
 

setuptools/tests/test_bdist_deprecations.py

@@ -0,0 +1,27 @@
+"""develop tests
+"""
+import mock
+import sys
+
+import pytest
+
+from setuptools.dist import Distribution
+from setuptools import SetuptoolsDeprecationWarning
+
+
+@pytest.mark.skipif(sys.platform == 'win32', reason='non-Windows only')
+@mock.patch('distutils.command.bdist_rpm.bdist_rpm')
+def test_bdist_rpm_warning(distutils_cmd):
+    dist = Distribution(
+        dict(
+            script_name='setup.py',
+            script_args=['bdist_rpm'],
+            name='foo',
+            py_modules=['hi'],
+        )
+    )
+    dist.parse_command_line()
+    with pytest.warns(SetuptoolsDeprecationWarning):
+        dist.run_commands()
+
+    distutils_cmd.run.assert_called_once()