Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up auto changelog on releases #1440

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jun 4, 2024

I noticed on the last release that the auto generated changelog included some bot entries. Those can be cleaned out with a config file like this.

Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call 👍

.github/release.yml Show resolved Hide resolved
@henryiii
Copy link
Contributor Author

henryiii commented Jun 4, 2024

I wonder if the [bot] is part of the name if if it's possible to match on that?

@Gitznik
Copy link
Contributor

Gitznik commented Jun 4, 2024

I wonder if the [bot] is part of the name if if it's possible to match on that?

Does not look like it from what I can see in the docs. I think this is fine 👍

@chrysle
Copy link
Contributor

chrysle commented Jun 4, 2024

Hmm, I think this might be needed; similar problem at jazzband/pip-tools#1976 (comment), but we didn't come to test it.

@henryiii
Copy link
Contributor Author

henryiii commented Jun 4, 2024

I've been using this as is in a bunch of repos, and it works, you don't need the trailing [bot] for sure; it would be nice though if you could trigger on it.

@gaborbernat gaborbernat merged commit 414c4e1 into pypa:main Jun 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants