Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support python3.8 for standalone python builds #1374

Merged
merged 2 commits into from
Apr 28, 2024
Merged

fix: support python3.8 for standalone python builds #1374

merged 2 commits into from
Apr 28, 2024

Conversation

huxuan
Copy link
Member

@huxuan huxuan commented Apr 26, 2024 •
edited
Loading

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fix #1375

Test plan

Tested by running

# command(s) to exercise these changes
nox -s tests
pipx install --verbose --python 3.8 --fetch-missing-python black

BTW, the tests on macos-latest is failed and I am trying to fix it in #1373 where I need python 3.8 interpreter for testing.

@huxuan huxuan changed the title fix: support python3.8 for standalone python build fix: support python3.8 for standalone python builds Apr 26, 2024
@huxuan huxuan marked this pull request as ready for review April 26, 2024 14:07
dukecat0
dukecat0 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@dukecat0 dukecat0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrysle chrysle merged commit 050c2d4 into pypa:main Apr 28, 2024
14 checks passed
@huxuan huxuan deleted the xuan.hu/spb-3.8 branch April 30, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dukecat0 dukecat0 dukecat0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.8 in Standalone Python Builds.
3 participants
@huxuan @dukecat0 @chrysle