-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Removed --python flag dependency when --force is passed #1306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look. I'm not convinces this actually adresses the issue though. Please see my other review comment.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine to me. Can you please add a test that verifies this behavior?
@Gitznik Doesn't |
That test didn't cover the bug you fixed, so we need a test that verifies that this bug can no longer happen. |
Done. Also added changelog.md file |
Fixes #1304
changelog.d/
(if the patch affects the end users)Summary of changes
Test plan
Tested by running