Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scoop installation instructions #1140

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Add Scoop installation instructions #1140

merged 7 commits into from
Dec 12, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Dec 11, 2023 •
edited by dukecat0
Loading

  • I have added an entry to docs/changelog.md

Ref: #338

Summary of changes

Add Scoop installation instructions in the readme

Test plan

Tested by running

# command(s) to exercise these changes

dukecat0
dukecat0 previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@dukecat0 dukecat0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dukecat0 dukecat0 enabled auto-merge (squash) December 11, 2023 05:11
@dukecat0 dukecat0 disabled auto-merge December 11, 2023 05:27
@dukecat0 dukecat0 enabled auto-merge (squash) December 11, 2023 05:27
@dukecat0 dukecat0 disabled auto-merge December 12, 2023 01:40
@dukecat0 dukecat0 enabled auto-merge (squash) December 12, 2023 10:10
@dukecat0
Copy link
Member

dukecat0 commented Dec 12, 2023 •
edited
Loading

Not sure why, but it seems like auto-merge doesn't work...

New changes require approval from someone other than dukecat0 because they were the last pusher.

Finally I saw it. 😅

@dukecat0 dukecat0 disabled auto-merge December 12, 2023 15:08
@dukecat0 dukecat0 requested a review from gaborbernat December 12, 2023 15:10
gaborbernat
gaborbernat approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 7128039 into pypa:main Dec 12, 2023
12 checks passed
@sitiom sitiom deleted the patch-1 branch December 13, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@dukecat0 dukecat0 dukecat0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sitiom @dukecat0 @gaborbernat