Skip to content

Bugfix: Make sure ensure_python() installs Python when conditions are met #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025
Merged

Bugfix: Make sure ensure_python() installs Python when conditions are met #6425

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a50c8c3
Bugfix: Make sure ensure_python() installs Python when conditions are…
EpiX-1 Jun 25, 2025
f626e8e
Add a news fragment
EpiX-1 Jun 27, 2025
2258f92
Update pipenv/utils/virtualenv.py
matteius Jun 27, 2025
9367bcd
Update 6425.bugfix.rst
matteius Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 28 additions & 34 deletions pipenv/utils/virtualenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,41 +326,35 @@ def abort(msg=""):
elif not project.s.PIPENV_YES:
# Non-interactive session without PIPENV_YES, proceed with installation
abort()
else:
# Tell the user we're installing Python.
console.print(
f"[bold]Installing [green]CPython[/green] {version} with {installer.cmd}[/bold]"
)
console.print("(this may take a few minutes)[bold]...[/bold]")
with console.status(
"Installing python...", spinner=project.s.PIPENV_SPINNER
):
try:
c = installer.install(version)
except InstallerError as e:
err.print(
environments.PIPENV_SPINNER_FAIL_TEXT.format("Failed...")
)
err.print("Something went wrong...")
err.print(f"[cyan]{e.err}[/cyan]")
else:
console.print(
environments.PIPENV_SPINNER_OK_TEXT.format("Success!")
)
# Print the results, in a beautiful blue...
err.print(f"[cyan]{c.stdout}[/cyan]")
# Find the newly installed Python, hopefully.
version = str(version)
path_to_python = find_a_system_python(version)

# Tell the user we're installing Python.
console.print(
f"[bold]Installing [green]CPython[/green] {version} with {installer.cmd}[/bold]"
)
console.print("(this may take a few minutes)[bold]...[/bold]")
with console.status("Installing python...", spinner=project.s.PIPENV_SPINNER):
try:
assert python_version(path_to_python) == version
except AssertionError:
err.print(
"[bold][red]Warning:[/red][/bold]"
" The Python you just installed is not available "
"on your [bold]PATH[/bold], apparently."
)
sys.exit(1)
c = installer.install(version)
except InstallerError as e:
err.print(environments.PIPENV_SPINNER_FAIL_TEXT.format("Failed..."))
err.print("Something went wrong...")
err.print(f"[cyan]{e.err}[/cyan]")
else:
console.print(environments.PIPENV_SPINNER_OK_TEXT.format("Success!"))
# Print the results, in a beautiful blue...
err.print(f"[cyan]{c.stdout}[/cyan]")
# Find the newly installed Python, hopefully.
version = str(version)
path_to_python = find_a_system_python(version)
try:
assert python_version(path_to_python) == version
except AssertionError:
err.print(
"[bold][red]Warning:[/red][/bold]"
" The Python you just installed is not available "
"on your [bold]PATH[/bold], apparently."
)
sys.exit(1)
return path_to_python


Expand Down
Loading