Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor in pip 24.2 #6263

Merged
merged 1 commit into from
Oct 4, 2024
Merged

vendor in pip 24.2 #6263

merged 1 commit into from
Oct 4, 2024

Conversation

matteius
Copy link
Member

@matteius matteius commented Sep 29, 2024

Vendor in pip 24.2

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius mentioned this pull request Sep 29, 2024
2 tasks
@matteius matteius requested a review from oz123 September 29, 2024 22:56
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I'm just wondering. I don't see any updates to the patch we apply when vendoring. Is this patch still working or we simply don't need to patch pip anymore?

@matteius
Copy link
Member Author

matteius commented Oct 4, 2024

@oz123 the existing patches that I updated for 24.1.2 still applied to 24.2 and didn't need amendments since those code paths hadn't further changed. I'd like to get this merged before I deep dive/debug the edge cases I've seen around vcs installs this week.

Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. Feel free to merge. Seems fine to me.

@matteius matteius merged commit de555d1 into main Oct 4, 2024
22 checks passed
@matteius matteius deleted the pip24.2-take3 branch October 4, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants