Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Issue #5129: Document how to rename (move) project directory #5824

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

langaa-egeskov
Copy link

The issue: Document how to rename or move a project directory

I was helped by the answer in issue #5123 and the further guidance in issue #5129

The fix: Added to existing documentation in 2 places

  • Added documentation in installation.md under 'Virtualenv' mapping caveat
  • Added documentation to the virtualenv.md

This is my first pull request so feedback very welcome.

The checklist

  • [X ] Associated issue
  • [ X] A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

langaaegeskov added 2 commits August 5, 2023 20:25
- Added documentation in installation.md under 'Virtualenv' mapping caveat
- Added documentation to the virtualenv.md
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Only a minor request for a change.

news/5129.doc.rst Outdated Show resolved Hide resolved
@langaa-egeskov langaa-egeskov requested a review from oz123 August 10, 2023 22:12
@langaa-egeskov
Copy link
Author

Sorry, I don't mean to leave this hanging. I'm working on resolving why the code linting and ruff tests are failing and I haven't figured it out yet.

@matteius
Copy link
Member

@IamAdiSri the ruff tests are a new issue because it keeps introducing new rules or inspecting new files -- it also happened on my draft-no-reqslib PR ... don't worry about it, just fix the main lint of the CI job and you'll be good.

@matteius
Copy link
Member

You can try running: pre-commit run --all-files --verbose --show-diff-on-failure --fix for the CI issue preventing your build.

@langaa-egeskov
Copy link
Author

thanks for the help! on my machine tests ran and seems sucessful
image

@oz123
Copy link
Contributor

oz123 commented Aug 17, 2023

All the failures that ruff reports have nothing to do with the PR.

@oz123 oz123 merged commit 5416f80 into pypa:main Aug 17, 2023
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants