Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markers being included as None/null #5788

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Fix markers being included as None/null #5788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a21f8c6
Fix markers being included as None/null
matteius Jul 10, 2023
5fdbcb1
Add news fragment.
matteius Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/5788.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix regression markers being included as None/null in requirements command.
4 changes: 3 additions & 1 deletion pipenv/routines/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def requirements_from_deps(deps, include_hashes=True, include_markers=True):
)
markers = (
"; {}".format(package_info["markers"])
if include_markers and "markers" in package_info
if include_markers
and "markers" in package_info
and package_info["markers"]
else ""
)
extras = (
Expand Down