Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] update --outdated raises NonExistentKey with dev package #5541

Merged
merged 2 commits into from
Dec 17, 2022

Conversation

shimpeko
Copy link
Contributor

closes #5540

The issue

#5540

The fix

Lookup the target package from the correct category instead of always using [package] category.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@shimpeko shimpeko force-pushed the fix-update-outdate-dev-package branch from 1f41495 to 4fa140d Compare December 16, 2022 15:36
@matteius
Copy link
Member

@shimpeko to fix the news fragment add double backticks around update --outdated

news/5540.bugfix.rst Outdated Show resolved Hide resolved
@oz123
Copy link
Contributor

oz123 commented Dec 16, 2022

Thank you for your contribution! Please check the review.

closes pypa#5540

pipenv update --outdated fail with NonExistentKey error when there are
outdated packages in dev-packages category.
@shimpeko shimpeko force-pushed the fix-update-outdate-dev-package branch from 9a7ddeb to 946040f Compare December 17, 2022 09:16
@oz123 oz123 merged commit 7322935 into pypa:main Dec 17, 2022
@shimpeko
Copy link
Contributor Author

@oz123 thank you fore review 🙏

@shimpeko shimpeko deleted the fix-update-outdate-dev-package branch December 17, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants