Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin converting away from pkg_resources #5351

Closed
wants to merge 6 commits into from
Closed

Begin converting away from pkg_resources #5351

wants to merge 6 commits into from

Conversation

matteius
Copy link
Member

Starts fixing #5349

The issue

  • Cleanup some patching to be consistent with how we patch pipenv to be available internal to pip __main__.py which is a more modern way using importlib that does not rely on pkg_resoruces.

There is more work to do to fully drop pkg_resources which seems to be what we are supposed to do: https://setuptools.pypa.io/en/latest/pkg_resources.html

image

The problem enters with pipdeptree is expecting the pkg_resources Distribution. I opened tox-dev/pipdeptree#175 to have that discussion.

@matteius matteius changed the title Issue 5349b Begin converting away from pkg_resources Sep 10, 2022
@oz123 oz123 self-requested a review September 10, 2022 12:13
@matteius
Copy link
Member Author

Ok, figured out my blockers with the prior PR, and so closing this in favor of: #5350
which will depend on: sarugaku/requirementslib#343

@matteius matteius closed this Sep 11, 2022
@matteius matteius deleted the issue-5349b branch September 11, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant