Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine the 20 slowest tests and make improvements. #5331

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Conversation

matteius
Copy link
Member

@matteius matteius commented Sep 6, 2022

On my fast laptop these were the 20 slowest tests:

259.54s call     tests/integration/test_lock.py::test_complex_lock_with_vcs_deps
254.14s call     tests/integration/test_install_uri.py::test_get_vcs_refs
253.65s call     tests/integration/test_install_twists.py::test_multiple_editable_packages_should_not_race
152.11s call     tests/integration/test_install_twists.py::test_local_zipfiles
137.95s call     tests/integration/test_lock.py::test_lock_editable_vcs_with_extras_without_install
133.73s call     tests/integration/test_lock.py::test_lock_nested_direct_url
133.52s call     tests/integration/test_lock.py::test_lock_editable_vcs_without_install
132.87s call     tests/integration/test_install_uri.py::test_install_editable_git_tag
130.86s call     tests/integration/test_lock.py::test_vcs_lock_respects_top_level_pins
130.70s call     tests/integration/test_uninstall.py::test_uninstall_all_local_files
127.40s call     tests/integration/test_install_twists.py::TestDirectDependencies::test_https_dependency_links_install
127.36s call     tests/integration/test_install_uri.py::test_basic_vcs_install_with_env_var
125.63s call     tests/integration/test_install_uri.py::test_basic_vcs_install
125.47s call     tests/integration/test_project.py::test_include_editable_packages
116.35s call     tests/integration/test_install_uri.py::test_editable_vcs_install
113.39s call     tests/integration/test_lock.py::test_lock_editable_vcs_with_markers_without_install
112.68s call     tests/integration/test_uninstall.py::test_uninstall_all_dev
111.80s call     tests/integration/test_lock.py::test_lock_editable_vcs_with_ref_in_git
109.92s call     tests/integration/test_cli.py::test_pipenv_clean_pip_no_warnings
109.60s call     tests/integration/test_install_twists.py::test_relative_paths

Here I examine them, make adjustments to what they should be doing to test (or if they should even exist in a couple cases, due to repeated test cases). After running the tests again:

pipenv/core.py Outdated Show resolved Hide resolved
@oz123 oz123 force-pushed the slowest-tests branch 2 times, most recently from d1e4438 to f46212e Compare September 7, 2022 17:15
@oz123 oz123 mentioned this pull request Sep 7, 2022
tests/integration/test_install_basic.py Show resolved Hide resolved
pipenv/core.py Outdated Show resolved Hide resolved
@oz123 oz123 merged commit 9527820 into main Sep 7, 2022
@oz123 oz123 deleted the slowest-tests branch September 7, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants