Update docs and add deprecation warning for lock -r #5069
Conversation
pipenv/cli/command.py
Outdated
| echo( | ||
| crayons.yellow( | ||
| """ | ||
| Warning: The lock flags -r/--requirements, along with it's options (--keep-outdated, --dev, --dev-only) |
There was a problem hiding this comment.
I think you cannot deprecate --keep-outdated because it is used to change the behavior of locking and thus install as well. I think the --dev or --dev-only may also be used similarly .. isn't --dev how you specify to only install the development requirements? I am not sure about --dev-only actually.
Otherwise I think this is the right direction to head in.
Unrelated, can you also have a look at this PR: #5071
There was a problem hiding this comment.
Oh one more thing, we are trying to not add any more crayons usage -- use click coloring instead. @oz123 will thank you. I have a recent example of doing just that: https://github.com/pypa/pipenv/pull/5046/files#diff-ef852c4ac364f946819f765a6bc26f04f1b0968f31fc512949a60fa2ab0685e8R903-R910
There was a problem hiding this comment.
Does requirements subcommand updates the packages? Is the default keep-outdated or update?
This should be clarified in the deperecation message.
|
@ImreC thank you for this contribution! |
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
@matteius I gave
pipenv lock -rsome more thought and I think we should over time deprecate it in favor ofpipenv requirements. This PR contains a deprecation warning and an update to the docs. Please let me know your thoughts