-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor pip 22.0.4 follow-up changes [Diff of actual changes to code] #4969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e lock process working again with the right versions, but the hashes are in fact missing still.
…. Want to see if the CI tests pass with this.
…urllib3 -- not sure how this test used to pass.
This comment was marked as resolved.
This comment was marked as resolved.
Closed
…me number of test failures no worse here
matteius
changed the title
Vendor pip 22.0.3 follow-up changes [Diff of actual changes to code]
Vendor pip 22.0.4 follow-up changes [Diff of actual changes to code]
Mar 9, 2022
…want to see that output.
…ith the downgrade of distlib.
This was referenced Mar 11, 2022
Closed
This was referenced Mar 12, 2022
This was not needed once the vendoring of new pip-shims and requirementslib were completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of many hours, debugging pip
22.0.3
working out the kinks to: #4966However two days ago
pip==22.0.4
was released and so I updated the parent branch vendoring to vendor to that, which resolved virtually all of the issues I had with22.0.3
that lead to code changes. I've since pulled out the code changes to the minimalist most changed which are:ALL TESTS NOW PASSING!!!
TODO
In both cases I have a workaround to the TODOs in this PR until those packages can be releases and then I can update the vendoring to include them and remove my manual changes there.
This requires dropping support for python 3.6 because pip 22.x dropped support, which should be fine since its EOL. However I recommend we do one more release of the other fixes in master before eventually doing a release that includes the pip vendoring updates.
Once the
requirementslib
andpipshims
have new releases I can vendor the parent PR and close down this one as it won't have any extra changes required, I think.