Consider environment variable PIP_TARGET when calculate depndancy delta #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
Nov 8, 2021
pipenv/environment.py
Outdated
| @@ -540,7 +540,7 @@ def get_distributions(self): | |||
| :rtype: iterator | |||
| """ | |||
|
|
|||
| libdirs = self.base_paths["libdirs"].split(os.pathsep) | |||
| libdirs = os.environ.get('PIP_TARGET', self.base_paths["libdirs"].split(os.pathsep)) | |||
There was a problem hiding this comment.
Should be return as a list
There was a problem hiding this comment.
@frostming
I fixed wrong type
matteius
approved these changes
Mar 12, 2022
oz123
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
#4775
The fix
When exec subcommand
installorsync, ifPIP_TARGETis set to environment variables, Refer specified directory for calculate delta, instead default directoryThe checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.