Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct python_version in pep508checker.py #4603

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

tucked
Copy link
Contributor

@tucked tucked commented Jan 27, 2021

The issue

Fix #4602

The fix

This includes all characters up to the second "." (instead of just the first 3 characters),
which should correct version-handling for Python 3.10.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@tucked tucked force-pushed the python_full_version branch from c947974 to e39ef1c Compare January 27, 2021 20:08
@tucked tucked marked this pull request as ready for review January 27, 2021 20:09
@frostming
Copy link
Contributor

Thanks for the fix

@frostming frostming merged commit 56f4ab4 into pypa:master Jan 28, 2021
@tucked tucked deleted the python_full_version branch January 28, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad version parsing in Python 3.10
2 participants