Skip to content

Fix for: --skip-lock: tomlkit.exceptions.NonExistentKey: 'Key "source" does not exist #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Conversation

noo0nee
Copy link
Contributor

@noo0nee noo0nee commented Dec 7, 2020

The issue

Issue #4141 --skip-lock: tomlkit.exceptions.NonExistentKey: 'Key "source" does not exist.'

The fix

Following the tip from @uranusjr, I set the sources to [DEFAULT_SOURCE] if the section [Sources] does not exist in PIPFILE.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@noo0nee noo0nee closed this Dec 7, 2020
@noo0nee noo0nee reopened this Dec 7, 2020
@Mause
Copy link

Mause commented Dec 7, 2020

Add a test so it isn't broken again?

@noo0nee
Copy link
Contributor Author

noo0nee commented Dec 7, 2020

Hello @Mause!
I need your help C:
How are these tests done? Can you please point me to a document/source that explains how?

@noo0nee
Copy link
Contributor Author

noo0nee commented Dec 7, 2020

I added a little test for the bug (I have read all the other tests). If something is wrong, please tell me and I will fix it.

Also... can someone tell me why Pipenv CI (Vendoring) is failing? This way I can fix it C:

@frostming frostming merged commit fce92de into pypa:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants