Add pipenv scripts command to list scripts in Pipfile
#4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `scripts` command and a test for it.
GlenRSmith
changed the title
pipenv scripts command to list scripts in Pipfilepipenv script command to list scripts in Pipfile
- Use string format compatible with python 2.7 - Use `click.echo`, not `print` - The command is `pipenv script` not `pipenv scripts` - The stanza label in Pipfile is `[scripts]`, not `[script]` - The default when getting from the pipfile should be dict, not a list
|
A news fragment is needed to notice what is new. You can place it under the |
frostming
added
the
PR: awaiting-news
|
Maybe we should name this |
Change the `script` command to `scripts`
GlenRSmith
changed the title
pipenv script command to list scripts in Pipfilepipenv scripts command to list scripts in Pipfile
uranusjr
reviewed
Sep 3, 2020
add inspection for 'which python'
frostming
requested changes
Sep 8, 2020
There was a problem hiding this comment.
One more step before merge: add a news entry file under news/ directory. @GlenRSmith
uranusjr
reviewed
Sep 8, 2020
pipenv/cli/command.py
Outdated
| for k, v in scripts.items(): | ||
| rpt += u"{0}\t{1}".format(k, v) | ||
| echo(rpt) | ||
| return |
|
@frostming Added. Sorry for the omission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement discussed in #3686