Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding PIPENV_INSTALL_TIMEOUT environment variable #3811

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

jerr0328
Copy link
Contributor

The issue

Fixes #3652 where PIPENV_INSTALL_TIMEOUT could not be changed. This was preventing users from setting longer timeouts when pipenv lock was taking over 15 minutes.

The fix

Follows similar format to other environment variables in environments.py to get the environment variable, while keeping the same default.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@frostming frostming merged commit 207f2f5 into pypa:master Jun 25, 2019
@jerr0328 jerr0328 deleted the bugfix/3652 branch June 25, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipenv ignores PIPENV_INSTALL_TIMEOUT
2 participants