-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2317 documentation variable expansion #2966
#2317 documentation variable expansion #2966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I accidentally committed the basic.rst, but this is not related to this issue
👍 Could you remove the changes in basic.rst so this merges cleanly? |
@uranusjr I tried git rebase -i and pushed again, I hope that this time this branch is OK to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Overall I would like to see the changes focused on conveying the meaning mentioned in the PR, and the additional changes about the windows variable reverted. Once we get that together, we can go ahead and move forward. Thanks :)
If you don't have the time to finish this up I can go ahead and make the final changes for you, just let me know |
Hi, so sorry for the delay, |
Signed-off-by: Dan Ryan <[email protected]>
The issue
Documentation should mention variable expansion works only in [[source]] entries #2317
The fix
As suggested I added the use of the operator only in the [[source]] section.
I also simplified the text on the alternatives of usage of variable expansion.