Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused sync options #2211

Closed
wants to merge 5 commits into from
Closed

Conversation

frostming
Copy link
Contributor

@frostming frostming commented May 17, 2018

Closes #2010

pipenv update --dry-run will also output not installed packages, as what's done in non dry-run mode. Here is what it produces:

$ pipenv sync --dry-run
Package 'requests' out–of–date: '==2.14.0' installed, '==2.18.4' available.
Package 'chardet==3.0.4' is not installed.
Package 'urllib3==1.22' is not installed.
Package 'idna==2.6' is not installed.
Package 'certifi==2018.4.16' is not installed.

@frostming
Copy link
Contributor Author

Does anyone know how to figure out what happened in the buildkite testing? I just got a 404.

@techalchemy
Copy link
Member

Sorry for the delay, we had some permissions issues -- I can give you an update on this once tests run again

@kennethreitz
Copy link
Contributor

@kennethreitz
Copy link
Contributor

this looks like a drastic change to our api, and i don't think it's what we want. i'd have to review more carefully — maintainers, feel free to re-open if needed.

@frostming
Copy link
Contributor Author

frostming commented May 24, 2018

That's fine. BTW, the test failure is caused by en dash in "out–of–date". I don't know whether it is more proper for en dash instead of hyphen in this case, just to throw it out to avoid similar failures in the future.

@uranusjr
Copy link
Member

uranusjr commented May 24, 2018

“out-of-date” should most definitely use hyphens, not en dashes. This is a grammatical fact, not a technical choice to prevent errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants