pipenv doesn't throw error, when `extras` are a string instead of a list-like #5440

con-f-use · 2022-10-24T15:51:45Z

[packages]
msal = {version="==1.20.0", extras="broker"}

Something like text above in a Pipfile, during locking, results in the bug evidenced by output below:

There are incompatible versions in the resolved dependencies:
  msal[b,e,k,o,r]==1.20.0 (from -r /run/user/1000/pipenvji73rdf6requirements/pipenv-mcbzzrng-constraints.txt (line 22))

It should error. Note that is not immediately obvious what is going wrong, as the letters in [b,e,k,o,r] are not even in the same order as the extra dependency "broker".

The text was updated successfully, but these errors were encountered:

oz123 · 2022-10-24T18:25:31Z

Question: have you added extras="broker" manually ?

con-f-use · 2022-10-24T21:40:04Z

I assume you mean as opposed to via pip install msal[broker]? Then yes, I have used an editor to change the Pipfile manually. Still pipenv should not mis-interpret that and iterate over a string because it expects a list here. If it expects a list, then it should throw an error "extras should be a list, not a string".

oz123 · 2022-10-24T21:42:52Z

I agree with you, but still, I wanted to know what the root cause was.

oz123 · 2022-10-25T08:12:52Z

Also, I think this should be fixed in https://github.com/sarugaku/plette

aidencullo · 2022-10-25T17:56:32Z

If this issue hasn't been resolved, I'd like to be assigned it. Especially considering it is a good first issue :)

oz123 · 2022-10-25T19:11:40Z

There you go 🙂 I think the actual fix is in plette but I might be wrong.

aidencullo · 2022-10-25T21:04:30Z

But should i check if it was fixed in plette? Would we still want it resolved in pipenv regardless?

…

El 25/10/2022, a las 2:11 p. m., Oz N Tiram ***@***.***> escribió: There you go 🙂 I think the actual fix is in plette but I might be wrong. — Reply to this email directly, view it on GitHub <#5440 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNQYBKNHUV6LAB3ESMIFS3WFAWHNANCNFSM6AAAAAARNDWO5I>. You are receiving this because you were assigned.

oz123 · 2022-10-25T21:08:20Z

The PR should be in that repository. You can prototype and test your changes on pipenv/vendor/plette but eventually the PR will go there.

aidencullo · 2022-11-18T21:01:03Z

Oz, is there some way I can contact you? I have some questions regarding this issue and pipenv in general that I'm not sure belong on this issue thread, my email is on my profile. Thanks

oz123 · 2022-11-19T13:47:24Z

Sent you and email. Feel to answer there.

oz123 · 2022-12-13T08:33:10Z

I was able to pin-point this bug. It's not about syncing, it's about requirements generation.

oznt@dell-gentoo:/tmp/pipenv-ncbhfaai-project $ cat Pipfile
[packages]
msal = {version="==1.20.0", extras="broker"}
oznt@dell-gentoo:/tmp/pipenv-ncbhfaai-project $ pipenv lock
Locking [packages] dependencies...
Locking [dev-packages] dependencies...
Updated Pipfile.lock (d5418ae7afddb195bc750352ac1c92fb7c0040ad281c7a4ca32db6c2a4ad2c7c)!
oznt@dell-gentoo:/tmp/pipenv-ncbhfaai-project $ pipenv requirements 
-i https://pypi.org/simple
certifi==2022.12.7 ; python_version >= '3.6'
cffi==1.15.1
charset-normalizer==2.1.1 ; python_full_version >= '3.6.0'
cryptography==38.0.4 ; python_version >= '3.6'
idna==3.4 ; python_version >= '3.5'
msal[b,e,k,o,r]==1.20.0
pycparser==2.21
pyjwt[crypto]==2.6.0 ; python_version >= '3.7'
requests==2.28.1 ; python_version >= '3.7' and python_version < '4'
urllib3==1.26.13 ; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'

The underlying problem is Pipfile.lock actually:

...
        "msal": {
            "extras": [
                "b",
                "e",
                "k",
                "o",
                "r"
            ],
...

Until now one could write anything in package extras. If one happend to write a string, e.g: ``` msal = {version="==1.20.0", extras="broker"} ``` It would silently pass, and result in a Pipfile.lock containing a list of characters: ``` "msal": { "extras": [ "b", "e", "k", "o", "r" ], ``` With this change, a validation is added to check that extras are a list. Also added is a check that packages specifiers are in a dictionary and not a list. This is a potential fix for pypa/pipenv#5440.

aidencullo · 2022-12-14T00:26:40Z

Hi Oz, Thank you for sending me this, i will look more into the requirements generation mechanism then. I haven’t had a lot of time to work on this recently, but i will have time this upcoming week and try to submit a fix by then. Best, Aiden

…

El 13/12/2022, a las 3:33 a. m., Oz N Tiram ***@***.***> escribió: I was able to pin-point this bug. It's not about syncing, it's about requirements generation. ***@***.***:/tmp/pipenv-ncbhfaai-project $ cat Pipfile [packages] msal = {version="==1.20.0", extras="broker"} ***@***.***:/tmp/pipenv-ncbhfaai-project $ pipenv lock Locking [packages] dependencies... Locking [dev-packages] dependencies... Updated Pipfile.lock (d5418ae7afddb195bc750352ac1c92fb7c0040ad281c7a4ca32db6c2a4ad2c7c)! ***@***.***:/tmp/pipenv-ncbhfaai-project $ pipenv requirements -i https://pypi.org/simple certifi==2022.12.7 ; python_version >= '3.6' cffi==1.15.1 charset-normalizer==2.1.1 ; python_full_version >= '3.6.0' cryptography==38.0.4 ; python_version >= '3.6' idna==3.4 ; python_version >= '3.5' msal[b,e,k,o,r]==1.20.0 pycparser==2.21 pyjwt[crypto]==2.6.0 ; python_version >= '3.7' requests==2.28.1 ; python_version >= '3.7' and python_version < '4' urllib3==1.26.13 ; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5' — Reply to this email directly, view it on GitHub <#5440 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNQYBLMSW5X2BHWSH72S33WNAYFDANCNFSM6AAAAAARNDWO5I>. You are receiving this because you were assigned.

matteius · 2022-12-14T02:23:36Z

I think Oz did a fix in palette for this today.

oz123 · 2022-12-14T06:05:25Z

It's already fixed in plette.

matteius · 2022-12-17T18:41:17Z

Please try pipenv==2022.12.17 which includes this fix.

con-f-use changed the title ~~pipenv doesn't throw error, when extras are a string insted of a container type~~ pipenv doesn't throw error, when extras are a string instead of a list-like Oct 24, 2022

oz123 added the good first issue Issues suitable as a newcomer to get familiar with Pipenv! label Oct 25, 2022

oz123 assigned aidencullo Oct 25, 2022

matteius added the Type: Possible Bug This issue describes a possible bug in pipenv. label Dec 3, 2022

oz123 mentioned this issue Dec 13, 2022

Add validation for extras in package specifiers sarugaku/plette#36

Merged

aidencullo removed their assignment Dec 14, 2022

oz123 mentioned this issue Dec 16, 2022

vendor: bump plette to 0.4.4 #5539

Merged

matteius closed this as completed Dec 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pipenv doesn't throw error, when `extras` are a string instead of a list-like #5440

pipenv doesn't throw error, when `extras` are a string instead of a list-like #5440

con-f-use commented Oct 24, 2022 •

edited

Loading

oz123 commented Oct 24, 2022

con-f-use commented Oct 24, 2022 •

edited

Loading

oz123 commented Oct 24, 2022

oz123 commented Oct 25, 2022

aidencullo commented Oct 25, 2022

oz123 commented Oct 25, 2022

aidencullo commented Oct 25, 2022 via email

oz123 commented Oct 25, 2022

aidencullo commented Nov 18, 2022

oz123 commented Nov 19, 2022 •

edited

Loading

oz123 commented Dec 13, 2022 •

edited

Loading

aidencullo commented Dec 14, 2022 via email

matteius commented Dec 14, 2022

oz123 commented Dec 14, 2022

matteius commented Dec 17, 2022

pipenv doesn't throw error, when extras are a string instead of a list-like #5440

pipenv doesn't throw error, when extras are a string instead of a list-like #5440

Comments

con-f-use commented Oct 24, 2022 • edited Loading

oz123 commented Oct 24, 2022

con-f-use commented Oct 24, 2022 • edited Loading

oz123 commented Oct 24, 2022

oz123 commented Oct 25, 2022

aidencullo commented Oct 25, 2022

oz123 commented Oct 25, 2022

aidencullo commented Oct 25, 2022 via email

oz123 commented Oct 25, 2022

aidencullo commented Nov 18, 2022

oz123 commented Nov 19, 2022 • edited Loading

oz123 commented Dec 13, 2022 • edited Loading

aidencullo commented Dec 14, 2022 via email

matteius commented Dec 14, 2022

oz123 commented Dec 14, 2022

matteius commented Dec 17, 2022

pipenv doesn't throw error, when `extras` are a string instead of a list-like #5440

pipenv doesn't throw error, when `extras` are a string instead of a list-like #5440

con-f-use commented Oct 24, 2022 •

edited

Loading

con-f-use commented Oct 24, 2022 •

edited

Loading

oz123 commented Nov 19, 2022 •

edited

Loading

oz123 commented Dec 13, 2022 •

edited

Loading