-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lock -r warning being logged to stdout instead of stderr #5091
Conversation
Thanks @tomarad -- would you add a |
Done @matteius. |
Slightly annoying, this bit me today here - actions/setup-python#398. If anyone sees this, be sure your pipenv in your actions is completely up to date as Or even better use something like |
Wow, should have realized this. Apologies and thanks for the fix |
@ImreC If it makes you feel better I've done the same thing in a recent release in a refactor of a print statement. |
hey all, I'm still getting this issue while using AWS CDK. It uses In my logs I can see that |
The release notes show that this PR (#5091) did not make it into the most recent release (v2022.4.30). This issue is currently breaking our CI/CD deployments which use the serverless-python-requirements plugin. |
@guyc I just tagged a new release for this issue. |
pipenv: 2022.5.2 works great!! ⚡️🚀🤘😃 |
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
The issue
In #5069, a deprecation message was added when
pipenv lock -r
is run.The warning message is written to stdout instead of stderr, breaking scripts that run commands like
pipenv lock -r > requirements.txt
.The fix
This PR directs the warning message to stderr instead of stdout.
I also de-dented the message to make it look nicer:
Old (notice the newline at the top):
New: