Warn about invalid extras during locking #3343

uranusjr · 2018-12-02T05:55:10Z

From #3026.

techalchemy · 2018-12-02T08:14:50Z

(Warn, but don’t fail)

ghost · 2018-12-03T11:40:01Z

Has anyone been assigned to this issue?

uranusjr · 2018-12-04T03:35:59Z

Nope, take it if you feel like it!

ghost · 2018-12-04T08:34:35Z

Thanks. I'm on it.

ghost · 2018-12-04T10:55:54Z

Fork the repository on GitHub.
Clone the fork.
Run tests before starting.

ghost · 2018-12-04T11:46:20Z

Development setup:

OS:
Edition->Windows 10 Pro,
Version->1809,
Build->17763.134

Device Specs:
System type->64-bit OS, x64-based processor,
Installed RAM: 16.0GB(15.9GB usable),
Processor: Intel Core i5-7400 CPU

Python: 3.7.1
WinPython: 3.7.1.0-64bit

ghost · 2018-12-04T12:22:14Z

I'm following CONTRIBUTING.md

Specifically, Development Setup section.

Note: Current directory is G:\...\Github\pypa pipenv issue #3343 and
ls gives d----- 04-12-2018 03:47 PM pipenv as output.

I know I need to setup my dev environment using

pip install -e .
pipenv install --dev

But I'm not thoroughly familiar with pip install -e

From which directory do I do pip install -e . ? I guess after I do cd pipenv but I want to double-check. For the second command I can pipenv install --dev from the pipenv directory as that's where the pipfile is.

Is there anything else I forgot?

techalchemy · 2018-12-04T15:31:02Z

pip install -e . is from the pipenv source directory and installs the latest source in development mode so updates you make are reflected on your system in real time. The second one does roughly the same thing but also gives you access to run the pipenv test suite which is a bit slow on windows but should work.

Looks like you’re set up, need to thank whoever wrote those docs!

ghost · 2018-12-12T00:40:28Z

Note to @snow8gaia:- 4 to 12 Dec 2018(till 2AM). Internet blackout.

ghost · 2018-12-12T00:42:19Z

pipenv install --dev does not work on my machine with:-
Python 3.7.1, 3.6.7
OS:
Edition->Windows 10 Pro,
Version->1809,
Build->17763.194

The command does not output any errors or warnings. But I can't run tests with pytest and pip list does not show any new packages( the ones listed in the [dev-packages] section of the Pipfile ) being installed. Maybe I need older python releases for installing the test-suite. Maybe I should try a Linux VM?

The fork is in sync with upstream.

I will try to do repeat same thing on a recent Ubuntu VM, maybe it works correctly and I am making a blunder(s).

ghost · 2018-12-15T08:59:24Z

w.r.t. issues in #3343 (comment)

Packages do get installed with python 3.7.1 on Win10, but maybe I was using pipenv run pip list from the wrong directory after 'pip install -e .' This one's probably my blunder.

In Testing section
Running tests with pytest works for 1st and 4th tests. The tests pass successfully.

But for pytest -k test_lock_editable_vcs_without_install or pytest it gets stuck at:-

Are you sure you want to continue connecting (yes/no)?
Please type 'yes' or 'no':
Please type 'yes' or 'no':

I type yes but it just keeps printing the same thing repeatedly. I try CTRL+C , Ctrl+Z Return , no response. Had to close the Powershell window to kill it. Then I tried it for the 2nd time. Same thing.

I then tried it again(3rd time), this time it accepted the response but didn't show it on screen( its not a password or is it? ). Or show a confirmation that the RSA key was stored. Also, this time it stopped at:-

rootdir: G:\FreqsV\Github\pypa pipenv issue #3343\pipenv, inifile: pytest.ini
plugins: xdist-1.23.2, tap-2.3, forked-0.2, flaky-3.4.0, pypi-0.1.1
gw0 [219] / gw1 [219] / gw2 [219] / gw3 [219]
scheduling tests via LoadScheduling
…

I try … to kill it.

Should I skip running all tests (and continue to next step)? Or do something else?

PS: I am using Powershell for running tests.

ghost · 2018-12-15T09:19:33Z

Tried it again, this time it showed:

gw0 [219] / gw1 [219] / gw2 [219] / gw3 [219]
scheduling tests via LoadScheduling
........s................s.........

I think the dots can be replaced with something that gives a concrete measure of progress in %, or just a uniform number of dots( I tried counting them).

Currently, sometimes it seems like the program is unresponsive or not working. This might confuse new contributors not familiar with confusing progress outputs to skip tests and continue to the next step.

EDIT: It takes way too long for the first [x%] to appear. I did see it but after going away for 5-8 minutes. If I used it for my work, 9min30s after I terminated the process.

ghost · 2018-12-15T09:43:11Z

=========================== short test summary info ===========================
FAIL tests/integration/test_install_twists.py::test_multiple_editable_packages_should_not_race
FAIL tests/integration/test_install_twists.py::TestDependencyLinks::()::test_https_dependency_links_install
FAIL tests/integration/test_install_uri.py::test_vcs_entry_supersedes_non_vcs
FAIL tests/integration/test_install_uri.py::test_file_urls_work
FAIL tests/integration/test_install_uri.py::test_install_local_vcs_not_in_lockfile
FAIL tests/integration/test_windows.py::test_local_path_windows
FAIL tests/integration/test_windows.py::test_local_path_windows_forward_slash
FAIL tests/integration/test_lock.py::test_vcs_lock_respects_top_level_pins
SKIP [1] tests\integration\test_cli.py:215: non-deterministic
SKIP [1] tests\integration\test_install_basic.py:80: Does not work unless you can explicitly install into py2
SKIP [1] tests\integration\test_install_basic.py:267: Not mocking this.
SKIP [1] tests\integration\test_install_markers.py:131: Skip for python 3.7
SKIP [2] G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:81: requires github ssh
SKIP [1] tests\integration\test_install_twists.py:126: this doesn't work on windows
SKIP [1] tests\integration\test_lock.py:194: Needs numpy to be mocked
SKIP [1] tests\unit\test_utils.py:127: don't need to test if unicode is str
SKIP [4] tests\unit\test_utils.py:269: *nix file paths tested
SKIP [1] tests\integration\test_lock.py:450: This doesn't work for some reason.
SKIP [1] tests\integration\test_lock.py:524: scandir doesn't get installed on python 3.5+
SKIP [1] tests\integration\test_pipenv.py:19: non deterministic

ghost · 2018-12-15T09:44:56Z

============================== warnings summary ===============================
G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:52: RuntimeWarning: Cannot connect to GitHub via SSH
  'Cannot connect to GitHub via SSH', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:55: RuntimeWarning: Will skip tests requiring SSH access to GitHub
  'Will skip tests requiring SSH access to GitHub', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:52: RuntimeWarning: Cannot connect to GitHub via SSH
  'Cannot connect to GitHub via SSH', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:55: RuntimeWarning: Will skip tests requiring SSH access to GitHub
  'Will skip tests requiring SSH access to GitHub', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:52: RuntimeWarning: Cannot connect to GitHub via SSH
  'Cannot connect to GitHub via SSH', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:55: RuntimeWarning: Will skip tests requiring SSH access to GitHub
  'Will skip tests requiring SSH access to GitHub', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:52: RuntimeWarning: Cannot connect to GitHub via SSH
  'Cannot connect to GitHub via SSH', RuntimeWarning

G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\conftest.py:55: RuntimeWarning: Will skip tests requiring SSH access to GitHub
  'Will skip tests requiring SSH access to GitHub', RuntimeWarning

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======= 8 failed, 195 passed, 16 skipped, 8 warnings in 2554.13 seconds =======

ghost · 2018-12-15T09:45:22Z

Command failed...
---------------------------- Captured stderr call -----------------------------
127.0.0.1 - - [15/Dec/2018 15:05:23] "GET /simple/urllib3/ HTTP/1.1" 200 694
127.0.0.1 - - [15/Dec/2018 15:05:23] "GET /urllib3/urllib3-1.21.1-py2.py3-none-any.whl HTTP/1.1" 200 131717
===Flaky Test Report===

test_extras_install passed 1 out of the required 1 times. Success!
test_outline_table_specifier passed 1 out of the required 1 times. Success!
test_top_level_overrides_environment_markers passed 1 out of the required 1 times. Success!
test_install_local_file_collision passed 1 out of the required 1 times. Success!
test_basic_vcs_install passed 1 out of the required 1 times. Success!
test_git_vcs_install passed 1 out of the required 1 times. Success!
test_urls_work passed 1 out of the required 1 times. Success!
test_editable_vcs_install passed 1 out of the required 1 times. Success!
test_install_editable_git_tag passed 1 out of the required 1 times. Success!
test_mirror_install passed 1 out of the required 1 times. Success!
test_install_without_dev passed 1 out of the required 1 times. Success!
test_backup_resolver passed 1 out of the required 1 times. Success!
test_platform_python_implementation_marker passed 1 out of the required 1 times. Success!
test_complex_deps_lock_and_install_properly passed 1 out of the required 1 times. Success!
test_bad_mirror_install passed 1 out of the required 1 times. Success!
test_install_without_dev_section passed 1 out of the required 1 times. Success!
test_alternative_version_specifier passed 1 out of the required 1 times. Success!
test_specific_package_environment_markers passed 1 out of the required 1 times. Success!
test_pipenv_check passed 1 out of the required 1 times. Success!
test_basic_install passed 1 out of the required 1 times. Success!
test_basic_dev_install passed 1 out of the required 1 times. Success!
test_windows_pinned_pipfile passed 1 out of the required 1 times. Success!
test_package_environment_markers passed 1 out of the required 1 times. Success!
test_global_overrides_environment_markers passed 1 out of the required 1 times. Success!
test_environment_variable_value_does_not_change_hash passed 1 out of the required 1 times. Success!
test_https_dependency_links_install failed (1 runs remaining out of 2).
        <class 'AssertionError'>
        assert 1 == 0
 +  where 1 = <Command 'pipenv install -v -e .'>.return_code
        [<TracebackEntry G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\test_install_twists.py:113>, <TracebackEntry G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\test_install_twists.py:101>]
test_https_dependency_links_install failed; it passed 0 out of the required 1 times.
        <class 'AssertionError'>
        assert 1 == 0
 +  where 1 = <Command 'pipenv install -v -e .'>.return_code
        [<TracebackEntry G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\test_install_twists.py:113>, <TracebackEntry G:\FreqsV\Github\pypa pipenv issue #3343\pipenv\tests\integration\test_install_twists.py:101>]
test_multiprocess_bug_and_install passed 1 out of the required 1 times. Success!
test_sequential_mode passed 1 out of the required 1 times. Success!
test_local_package passed 1 out of the required 1 times. Success!
test_local_zipfiles passed 1 out of the required 1 times. Success!
test_relative_paths passed 1 out of the required 1 times. Success!

===End Flaky Test Report===

ghost · 2018-12-15T09:48:49Z

I have not added SSH access to GitHub, so I think the 8 failed tests in #3343 (comment) can be ignored safely.

Unless I am missing something, I think it's time for the next step.

techalchemy · 2018-12-15T18:29:56Z

We don’t ignore failing tests. Note how one of our tests are failing in CI. You don’t need to post updates here, if you think your branch will pass our tests, I.e that these are not applicable, make a pull request and it will be auto-tested

ghost · 2018-12-16T20:41:47Z

I just synced the fork with upstream. Now, both are identical. Can't make PR now.

I will test again after I check the failing tests.

ghost · 2018-12-25T08:03:10Z

I give up. This issue has no assignees as of now.

Some unforeseen issues have come up on my end that will cause a massive delay.

Thanks for everything.

techalchemy · 2018-12-25T16:38:57Z

We don’t typically assign things. You are free to work on it or no, but if you have an open pull request please keep communication there for now

ghost · 2019-02-15T16:03:53Z

I have started working on this. I'll make a dummy PR in a while.

Link

https://github.com/snow8gaia/pipenv

ghost · 2019-02-15T18:23:20Z

#3539

uranusjr added the Type: Enhancement 💡 This is a feature or enhancement request. label Dec 2, 2018

techalchemy added Category: Future Issue is planned for the future. good first issue Issues suitable as a newcomer to get familiar with Pipenv! help wanted labels Dec 2, 2018

ghost mentioned this issue Feb 16, 2019

dummy - To fix #3343 #3539

Closed

2 tasks

matteius closed this as completed Aug 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn about invalid extras during locking #3343

Warn about invalid extras during locking #3343

uranusjr commented Dec 2, 2018

techalchemy commented Dec 2, 2018

ghost commented Dec 3, 2018

uranusjr commented Dec 4, 2018

ghost commented Dec 4, 2018

ghost commented Dec 4, 2018 •

edited by ghost

Loading

ghost commented Dec 4, 2018 •

edited by ghost

Loading

ghost commented Dec 4, 2018

techalchemy commented Dec 4, 2018

ghost commented Dec 12, 2018

ghost commented Dec 12, 2018 •

edited by ghost

Loading

ghost commented Dec 15, 2018 •

edited by ghost

Loading

ghost commented Dec 15, 2018 •

edited by ghost

Loading

ghost commented Dec 15, 2018

ghost commented Dec 15, 2018

ghost commented Dec 15, 2018

ghost commented Dec 15, 2018 •

edited by ghost

Loading

techalchemy commented Dec 15, 2018

ghost commented Dec 16, 2018

ghost commented Dec 25, 2018

techalchemy commented Dec 25, 2018

ghost commented Feb 15, 2019

ghost commented Feb 15, 2019

Warn about invalid extras during locking #3343

Warn about invalid extras during locking #3343

Comments

uranusjr commented Dec 2, 2018

techalchemy commented Dec 2, 2018

ghost commented Dec 3, 2018

uranusjr commented Dec 4, 2018

ghost commented Dec 4, 2018

ghost commented Dec 4, 2018 • edited by ghost Loading

ghost commented Dec 4, 2018 • edited by ghost Loading

ghost commented Dec 4, 2018

techalchemy commented Dec 4, 2018

ghost commented Dec 12, 2018

ghost commented Dec 12, 2018 • edited by ghost Loading

ghost commented Dec 15, 2018 • edited by ghost Loading

ghost commented Dec 15, 2018 • edited by ghost Loading

ghost commented Dec 15, 2018

ghost commented Dec 15, 2018

ghost commented Dec 15, 2018

ghost commented Dec 15, 2018 • edited by ghost Loading

techalchemy commented Dec 15, 2018

ghost commented Dec 16, 2018

ghost commented Dec 25, 2018

techalchemy commented Dec 25, 2018

ghost commented Feb 15, 2019

ghost commented Feb 15, 2019

ghost commented Dec 4, 2018 •

edited by ghost

Loading

ghost commented Dec 4, 2018 •

edited by ghost

Loading

ghost commented Dec 12, 2018 •

edited by ghost

Loading

ghost commented Dec 15, 2018 •

edited by ghost

Loading

ghost commented Dec 15, 2018 •

edited by ghost

Loading

ghost commented Dec 15, 2018 •

edited by ghost

Loading