Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError: No module named 'XXXXX'. version 2018.6.25 #2421

Closed
ikosenn opened this issue Jun 26, 2018 · 13 comments
Closed

ModuleNotFoundError: No module named 'XXXXX'. version 2018.6.25 #2421

ikosenn opened this issue Jun 26, 2018 · 13 comments
Labels
Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Milestone

Comments

@ikosenn
Copy link

ikosenn commented Jun 26, 2018

After updating to version: 2018.6.25. I get the error as shown in the image attached. facematic is the package name in setup.py. I get the error while running the command pipenv install -e .

screen shot 2018-06-26 at 02 56 04

Steps to replicate
  1. Get a python package
  2. Run pipenv install -e .
@ikosenn
Copy link
Author

ikosenn commented Jun 26, 2018

On a different package. This time I used the command pipenv install --dev

screen shot 2018-06-26 at 03 10 01

@notofir
Copy link

notofir commented Jun 26, 2018

I've had the same error after upgrading to v2018.6.25.

@uranusjr
Copy link
Member

Could you share your setup.py?

@erinxocon
Copy link
Contributor

erinxocon commented Jun 26, 2018

Hi @ikosenn, thanks for using pipenv! In addition to the setup.py can we see the directory structure?

@mmellison
Copy link

I'm having the exact same issue:

ModuleNotFoundError: No module named 'versioneer'

See https://gist.github.com/seglberg/97c47832d2997d47b345c189fbb1aad4

@erinxocon
Copy link
Contributor

@seglberg is your repo public and something I could pull down for testing? I can't seem to replicate the issue.

@mmellison
Copy link

No, it is private. I can create a sample repository that reproduces the error. Hang tight.

@uranusjr
Copy link
Member

I would first point out it is against best practice to import your library in its setup.py. It creates a chicken-egg problem—Usually the user cannot import dependencies before your package is installed, but without running setup.py pip cannot resolve dependencies for the user.

I would recommend adopting on of the top solutions mentioned in the Python Packaging User Guide.

@mmellison
Copy link

See https://github.com/seglberg/pipenv-repro
pipenv install fails inside the python directory

We are not importing any of the package's modules inside setup, we import a top-level, standalone module which generates our version information. My initial thought is that its a python path issue.

@uranusjr
Copy link
Member

Ah, I see, sorry for the misunderstanding. Indeed this seems to be a path issue. Also we should probably be more resilient when reading the package name.

@mmellison
Copy link

mmellison commented Jun 26, 2018

If I modify my setup.py, it works:

HERE = os.path.dirname(os.path.abspath(__file__))
sys.path.append(HERE)
import versioneer

So definitely a path issue.

@techalchemy techalchemy added Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. labels Jun 26, 2018
@techalchemy techalchemy added this to the 2018.6.26 milestone Jun 26, 2018
@techalchemy
Copy link
Member

Thanks for the reports all, fix will be out shortly

techalchemy added a commit that referenced this issue Jun 26, 2018
techalchemy added a commit that referenced this issue Jun 27, 2018
techalchemy added a commit that referenced this issue Jun 27, 2018
Update requirementslib to fix #2421
@jeremyarr
Copy link

Well done for getting a fix in the master out so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Development

No branches or pull requests

7 participants