Switch all update workflows to pipenv lock/sync
#2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jun 18, 2018
pipenv/cli.py
Outdated
| ) | ||
| do_sync( | ||
| ctx=ctx, | ||
| install=install, |
There was a problem hiding this comment.
It is a good time to clean up arguments of sync now? (#2211 but maybe less drastic, just remove those that are really unused). My eyes roll every time I see it.
There was a problem hiding this comment.
i only cleaned up a few -- some i think we want to implement
- `pipenv update` currently doesn't actually run `pipenv lock` - Semantics around this changed but it doesn't look like the code did - `pipenv update` should operate similarly for all operations by running `lock` followed by `sync` - Fixes #2179 Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
techalchemy
force-pushed
the
2179-pipenv-update
branch
from
04c1fce to
0ce5b3c
Compare
uranusjr
approved these changes
Jun 18, 2018
uranusjr
added
the
PR: awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv updatecurrently doesn't actually runpipenv lockpipenv updateshould operate similarly for all operations by runninglockfollowed bysync