Fix pipfile creation with unnamed project

- Fixes #3260 Signed-off-by: Dan Ryan <[email protected]>
pypa · Nov 20, 2018 · f99de85 · f99de85
1 parent 206a59c
commit f99de85
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/news/3260.bugfix.rst b/news/3260.bugfix.rst
@@ -0,0 +1 @@
+Fixed an issue which sometimes prevented successful creation of project pipfiles.
diff --git a/pipenv/project.py b/pipenv/project.py
@@ -693,6 +693,7 @@ def create_pipfile(self, python=None):
             ConfigOptionParser, make_option_group, index_group
         )
 
+        name = self.name if self.name is not None else "Pipfile"
         config_parser = ConfigOptionParser(name=self.name)
         config_parser.add_option_group(make_option_group(index_group, config_parser))
         install = config_parser.option_groups[0]

diff --git a/tests/integration/test_install_basic.py b/tests/integration/test_install_basic.py
@@ -418,3 +418,11 @@ def test_system_and_deploy_work(PipenvInstance, pypi):
         )
         c = p.pipenv("install --system")
         assert c.return_code == 0
+
+
+@pytest.mark.install
+def test_install_creates_pipfile(PipenvInstance):
+    with PipenvInstance(chdir=True) as p:
+        c = p.pipenv("install")
+        assert c.return_code == 0
+        assert os.path.isfile(p.pipfile_path)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed an issue which sometimes prevented successful creation of project pipfiles.