Escape command line requirements as necessary

- Fixes #2998 Signed-off-by: Dan Ryan <[email protected]>
pypa · Oct 11, 2018 · 12e80ed · 12e80ed
1 parent 485da19
commit 12e80ed
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/news/2998.bugfix b/news/2998.bugfix
@@ -0,0 +1 @@
+Fixed a bug which prevented installing pinned versions which used redirection symbols from the command line.
diff --git a/pipenv/core.py b/pipenv/core.py
@@ -40,6 +40,7 @@
     rmtree,
     clean_resolved_dep,
     parse_indexes,
+    escape_cmd
 )
 from . import environments, pep508checker, progress
 from .environments import (
@@ -1398,6 +1399,7 @@ def pip_install(
         pip_command.append("--upgrade-strategy=only-if-needed")
     if no_deps:
         pip_command.append("--no-deps")
+    install_reqs = [escape_cmd(req) for req in install_reqs]
     pip_command.extend(install_reqs)
     pip_command.extend(prepare_pip_source_args(sources))
     if not ignore_hashes:

diff --git a/pipenv/utils.py b/pipenv/utils.py
@@ -1048,6 +1048,12 @@ def handle_remove_readonly(func, path, exc):
     raise
 
 
+def escape_cmd(cmd):
+    if any(special_char in cmd for special_char in ["<", ">", "&", ".", "^", "|", "?"]):
+        cmd = '\'{0}\''.format(cmd)
+    return cmd
+
+
 @contextmanager
 def atomic_open_for_write(target, binary=False, newline=None, encoding=None):
     """Atomically open `target` for writing.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed a bug which prevented installing pinned versions which used redirection symbols from the command line.