Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Requires-Python before other dependencies #9994

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

uranusjr
Copy link
Member

This makes the resolver fail quicker when there's a interpreter version conflict, and avoid additional (useless) downloads.

Fix #9925.

@uranusjr uranusjr closed this May 19, 2021
@uranusjr uranusjr reopened this May 19, 2021
@uranusjr uranusjr added this to the 21.2 milestone May 19, 2021
news/9925.feature.rst Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Do you want to add a test ensuring that no other checks happen once there's a Python version mismatch?

This makes the resolver fail quicker when there's a interpreter
version conflict, and avoid additional (useless) downloads.
@uranusjr uranusjr force-pushed the requires-python-before-other-deps branch from 2bbf7b4 to c8638ad Compare June 1, 2021 17:55
@uranusjr
Copy link
Member Author

uranusjr commented Jun 1, 2021

Test added. I also changed the implementation to use Provider.get_preference() instead, which is less magical to me than relying on the dependencies’ internal ordering.

@uranusjr uranusjr merged commit 7c3abcc into pypa:main Jun 15, 2021
@uranusjr uranusjr deleted the requires-python-before-other-deps branch June 15, 2021 11:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform Requires-Python check before downloading dependencies
4 participants