-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of concept for #9603 #9607
Conversation
TIL I tested with a project that uses setuptools-scm and it seems to work fine. @RonnyPfannschmidt you may want to give it a try. There might be gotchas but this is worth exploring. Thanks @kumaraditya303 |
@pradyunsg you may want to give this PR a try. |
Hi @kumaraditya303, Are you closing this PR out of lack of patience or frustration, or because you discovered a flaw ? I personally think this is something worth exploring. I had a look again at this and I found this relatively recent article at github.com which gives food for thought. Another question I have is about minimum git client and server version. It would be interesting to know the minimum requirements to determine if we need to fallback to the full clone in some circumstances? Also, if we do this we probably want to do it for non editable requirements first and leave editable requirements doing a full clone, as users who use editable VCS URLs probably want to develop in the local tree. |
Hi @sbidoul, |
@sbidoul |
I reopened the issue. You must understand that the pip team is small, and the topics to address numerous, so yeah, patience and occasional gentle nudges, and things move eventually :) I personally tested it and it seems to works, but we must be careful, so if you can help researching the questions I mentioned above that would certainly help! |
I am open for discussion on issue if you need some info about the change |
@kumaraditya303 thanks for the nudge and sorry for the delay in responding to it here. Could you file a new PR with this change? Pinging @RonnyPfannschmidt as well, since setuptools-scm is likely the main project that we want to know that this works fine with, and they're the only person I know who works on that. :) As an aside, what @sbidoul said about lots of things pulling for pip's maintainers' attention is very true! For context, I got around to this from my "unread mentions" search in my GitHub notifications bucket (there's 210 unread notifications total, and many more still-actionable-and-read items). 😅 |
Actually, didn't get why a new PR is need for just the same change... |
Treeless works fine for setuptools_scm Just commits and tags are needed |
Will create new one ! |
Yes treeless clone works perfectly for setuptools-scm as it has the required metadata |
Concept for cloning repo treeless hence saving disk space and bandwidth.
#9603 (comment)
@uranusjr