Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all resolution conflict fix info on stderr. #9421

Closed
wants to merge 1 commit into from
Closed

Include all resolution conflict fix info on stderr. #9421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/9420.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Include all resolution conflict fix info on stderr.
7 changes: 3 additions & 4 deletions src/pip/_internal/resolution/resolvelib/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,8 @@ def describe_trigger(parent):
info = "the requested packages"

msg = "Cannot install {} because these package versions " \
"have conflicting dependencies.".format(info)
logger.critical(msg)
msg = "\nThe conflict is caused by:"
"have conflicting dependencies.\n".format(info)
msg = msg + "\nThe conflict is caused by:"
for req, parent in e.causes:
msg = msg + "\n "
if parent:
Expand All @@ -489,7 +488,7 @@ def describe_trigger(parent):
"2. remove package versions to allow pip attempt to solve " + \
"the dependency conflict\n"

logger.info(msg)
logger.critical(msg)

return DistributionNotFound(
"ResolutionImpossible: for help visit "
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/test_install_reqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,10 +601,10 @@ def test_install_distribution_union_with_versions(
assert "Cannot install localextras[bar]" in result.stderr
assert (
"localextras[bar] 0.0.1 depends on localextras 0.0.1"
) in result.stdout
) in result.stderr
assert (
"localextras[baz] 0.0.2 depends on localextras 0.0.2"
) in result.stdout
) in result.stderr
else:
assert (
"Successfully installed LocalExtras-0.0.1 simple-3.0 "
Expand Down