Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete type annotations in "pip._internal.{build_env,self_outdated_check,exceptions}" #8296

Merged
merged 7 commits into from
May 31, 2020
Merged

Complete type annotations in "pip._internal.{build_env,self_outdated_check,exceptions}" #8296

merged 7 commits into from
May 31, 2020

Conversation

deveshks
Copy link
Contributor

Towards #4748

Added type annotations to pip._internal.req.build_env, pip._internal.self_outdated_check and pip._internal.network.exceptions

@deveshks deveshks force-pushed the mypy-pip-internal branch from 625a206 to 6de7f12 Compare May 22, 2020 05:17
@deveshks deveshks force-pushed the mypy-pip-internal branch from 58d8db3 to 5903efe Compare May 22, 2020 07:58
@deveshks deveshks force-pushed the mypy-pip-internal branch from 5903efe to 6de7f12 Compare May 22, 2020 09:53
@deveshks deveshks force-pushed the mypy-pip-internal branch from 6de7f12 to 7e4280a Compare May 22, 2020 10:17
@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label May 22, 2020
@deveshks deveshks requested a review from pradyunsg May 22, 2020 13:57
pradyunsg
pradyunsg reviewed May 22, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly! :-)

src/pip/_internal/exceptions.py Outdated Show resolved Hide resolved
src/pip/_internal/exceptions.py Outdated Show resolved Hide resolved
src/pip/_internal/build_env.py Outdated Show resolved Hide resolved
src/pip/_internal/build_env.py Outdated Show resolved Hide resolved
@deveshks deveshks requested a review from pradyunsg May 23, 2020 05:11
@deveshks deveshks force-pushed the mypy-pip-internal branch from 217d808 to 4fbe61a Compare May 23, 2020 08:59
@deveshks deveshks requested a review from sbidoul May 23, 2020 08:59
@deveshks
Copy link
Contributor Author

I think this is good to go, and can be merged.

@deveshks
Copy link
Contributor Author

Thanks for the approval folks. I think this can be merged now 😊

@sbidoul sbidoul merged commit 69a4cb3 into pypa:master May 31, 2020
@deveshks deveshks deleted the mypy-pip-internal branch May 31, 2020 17:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@McSinyx McSinyx McSinyx left review comments

@gutsytechster gutsytechster gutsytechster left review comments

@sbidoul sbidoul sbidoul approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deveshks @sbidoul @pradyunsg @McSinyx @gutsytechster