Reorder methods in req_install to better group them #5452
Conversation
pradyunsg
added
type: refactor
pradyunsg
changed the title
| @@ -129,6 +129,8 @@ def __init__(self, req, comes_from, source_dir=None, editable=False, | |||
| self.isolated = isolated | |||
| self.build_env = NoOpBuildEnvironment() | |||
|
|
|||
| # Constructors | |||
| # TODO: Move these out of this class into custom methods. | |||
There was a problem hiding this comment.
obvious typo here: methods -> functions.
There was a problem hiding this comment.
(it'll get removed in #5455, so this staying in is not really a major issue)
| def from_path(self): | ||
| """Format a nice indicator to show where this "comes from" |
There was a problem hiding this comment.
This doc-string slipped through. Letting this stay coz it adds value. :)
| """Find an installed distribution that satisfies or conflicts | ||
| with this requirement, and set self.satisfied_by or | ||
| self.conflicts_with appropriately. | ||
| """ | ||
| if self.req is None: |
There was a problem hiding this comment.
This is just git anchoring the diff weirdly.
pradyunsg
force-pushed
the
refactor/reorder-req-install-methods
branch
from
4277d04 to
47d58b8
Compare
|
@pfmoore Could you take a look at this, when you find some time? |
|
Not in the near future, sorry. I'm mad busy through till July, so only snatching bits of time till then, and I don't feel I can say anything meaningful on this based on the sort of quick skim that's all I can give it right now. Sorry! |
Noted.
No issues. :) I'm happy to merge this and a few more similar PRs, without someone else reviewing them, if no one else in @pypa/pip-committers has the time to review. Would you mind that? |
|
This is basically a copy-paste change. I'm happy to merge w/o complete reviews into this. |
lock
bot
added
the
auto-locked
Toward #5051.
Getting the grouping of methods wrong here shouldn't really hurt much since this is intended to merely aid any work for #5051. :)