Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement working scheme #4871

Closed
wants to merge 4 commits into from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Nov 16, 2017

Closes #4575

This PR also:

I'm open to the idea of breaking this PR up but I think these changes are intertwined enough that we should consider them all in one bundle.

Since this is a topic that probably needs some discussion, I feel it'd be best to only discuss implementation related stuff here and have all the higher level discussion over at #4575.

I still need to make this refuse to install stuff in different schemes, write tests and documentation and probably more stuff. I'd appreciate some more eyeballs passing through this code though now.

TODO + self-notes
  • Code
  • Tests
    • Ensure no existing tests need changing
    • Lots of tests? Just enough tests? Somewhere in the middle?
    • Think then bring up.
  • Documentation
    • Options:
      • Rewrite the section "user installs"
      • Write a new "installation scheme"
    • Think then bring up.
  • News
  • pip config uses --global, --user, --venv; maybe they should be changed too?
    • Think then bring up.

* Add a --global flag
* Implement a fallback logic for smartly trying to determine the correct
  working scheme when not explicitly given.
* Update error messages for the change in options.
@pradyunsg pradyunsg added state: needs discussion This needs some more discussion type: feature request Request for a new feature C: user scheme Handling of packages in user-specific directories labels Nov 16, 2017
@pradyunsg pradyunsg self-assigned this Nov 16, 2017
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Nov 24, 2017
@pradyunsg pradyunsg added S: needs triage Issues/PRs that need to be triaged and removed type: feature request Request for a new feature labels May 11, 2018
@pradyunsg pradyunsg closed this Jun 17, 2018
@pradyunsg pradyunsg deleted the feature/working-scheme branch June 17, 2018 06:48
@tuukkamustonen
Copy link

@pradyunsg Do you have new plans with this, no recent discussion in #4575 at least?

@pradyunsg
Copy link
Member Author

This got closed since I cleaned up the stale branches on my fork and this was one of them.

No new plans for this. Mostly just a matter of me getting/making time to do this. If I hit something unexpected, I'll make a comment over on that issue.

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: user scheme Handling of packages in user-specific directories needs rebase or merge PR has conflicts with current master state: needs discussion This needs some more discussion
Projects
None yet
3 participants