-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update non PEP 440 wheel filename deprecation notice #12939
Merged
sbidoul
merged 5 commits into
pypa:main
from
notatallshaw:update-non-PEP-440-wheel-filename-deprecation-notice
Oct 12, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aa25c97
Update non PEP 440 wheel filename deprecation notice
notatallshaw fbe7924
NEWS ENTRY
notatallshaw 7ddafd0
Merge branch 'main' into update-non-PEP-440-wheel-filename-deprecatio…
notatallshaw 9fd6b86
Merge branch 'main' into update-non-PEP-440-wheel-filename-deprecatio…
notatallshaw 0c4cdf9
Break up different exceptions and report specific error
notatallshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Update non PEP 440 wheel filename deprecation notice. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads poorly:
That period seems superfluous? "pip will fail to recognise this wheel. and report the error"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞 , yes, I should have done another read over of the error before pushing the commit, I didn't expect it to actually ever trigger though.
Does your example actually cause this error to trigger? i.e. it passes the regex but not the
parse_wheel_filename
?I can make yet another follow up to improve the wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it up by renaming the random six wheel I have lying around. It should not be considered a real world example :P
It did work in raising this error though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a PR tomorrow aimed to be as small as possible to clean up the wording. Thanks for pointing out.