Fix build isolation on Pythons where purelib/platlib aren't enough #11466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it helps, this gist: https://gist.github.com/minrk/6d73fc9159448f1f83f8a6d5c2b2dfac has a regression test on ubuntu:22.04 that fails with pip 22.2.2, and works with this PR. |
use site.getsitepackages() where available instead of just purelib/platlib, which is often insufficient on e.g. System Pythons for Debian/macOS handle virtualenv < 20 overwriting site.py without getsitepackages() by preserving current behavior.
minrk
force-pushed
the
build_env_isolation
branch
from
93a2424
to
24773bc
Compare
pradyunsg
approved these changes
Sep 23, 2022
uranusjr
approved these changes
Sep 26, 2022
|
Thanks @minrk! ^>^ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
site.getsitepackages()where available instead of just purelib/platlib, which is sometimes insufficient on e.g. System Pythons for Debian/macOS.handle
virtualenv < 20overwriting site.py without getsitepackages() by preserving current behavior. I think the cases where this fix is needed and site.py is overwritten are mutually exclusive, so this should be okay. At the very least, it should be an improvement in all cases where behavior is changed.I don't know how to write a great test, since it needs to actually run against system Python on Mac or Debian outside a virtualenv in order to directly test this. As it is, the added test only assumes that
site.getsitepackages()is right to remove and then removed, which is a bit tautological.closes #6264