-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendoring upgrade #10815
Vendoring upgrade #10815
Conversation
4317ea2
to
23eae53
Compare
These are newly vendored and this "upgrade" is the wrong verb to use.
27b8946
to
aba689c
Compare
Hi @pradyunsg, looking forward to the upcoming pip release! 😸 If you want, it should be possible to bump PR #10238 should also unlock 2.0.0 for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure how I can usefully review this, but it looks OK on a skim, and as long as the CI passes, that works for me.
Hey - Is it not possible to not bundle the pre-built .exe files with distlib? I recall this behaviour being previously flagged as a bug in https://bugzilla.redhat.com/show_bug.cgi?id=2006788 and was wondering why we re-introduced them. |
@johnhany97 The executables are essential for building script wrappers on Windows, so no, it's not possible to omit them. We've never omitted them, I don't know if Redhat did something in the past to remove them as part of their pip patching, but that would be down to them, not us. |
Got it - Thank you for the speedy reply @pfmoore |
Closes #10708