Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation of PipProvider._known_depths #10482

Merged
merged 18 commits into from
Sep 26, 2021
Merged

Fix calculation of PipProvider._known_depths #10482

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
43557d7
Fix known depth calculation
notatallshaw Sep 16, 2021
bba7e31
Add news item
notatallshaw Sep 22, 2021
f670368
Newline
notatallshaw Sep 22, 2021
4cd08f7
News items attempt 2
notatallshaw Sep 22, 2021
27da199
First attempt at provider known depths test
notatallshaw Sep 23, 2021
478c5e5
Remove comments, add new line
notatallshaw Sep 23, 2021
4852663
Fix lint issues
notatallshaw Sep 23, 2021
0e40c94
Fix comment
notatallshaw Sep 23, 2021
b8ff7f3
Replace build_iter_view with iter
notatallshaw Sep 23, 2021
f226b2f
Fix linting
notatallshaw Sep 23, 2021
7242912
Simplify test
notatallshaw Sep 23, 2021
d7bd6dc
Typo
notatallshaw Sep 23, 2021
8aef5c2
Add argument names
notatallshaw Sep 23, 2021
9844d79
Better names
notatallshaw Sep 23, 2021
23050df
Replace requirement creation with install_req_from_req_string
notatallshaw Sep 23, 2021
d311c8c
further simplification
notatallshaw Sep 24, 2021
9c52c75
Deep is more consistent than down
notatallshaw Sep 26, 2021
105a328
Update news/10482.bugfix.rst
notatallshaw Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pip/_internal/resolution/resolvelib/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ def get_preference(
for _, parent in information[identifier]
)
inferred_depth = min(d for d in parent_depths) + 1.0
self._known_depths[identifier] = inferred_depth
else:
inferred_depth = 1.0
self._known_depths[identifier] = inferred_depth

requested_order = self._user_requested.get(identifier, math.inf)

Expand Down