662 duplicates are not supported in requirements.txt when run with disable pip #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @mathbou! I'll review this today. |
woodruffw
reviewed
Mar 18, 2024
woodruffw
reviewed
Mar 18, 2024
woodruffw
reviewed
Mar 18, 2024
…uirements.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
|
It's been a while here, is there anything that prevent us to go further with this PR ? @woodruffw |
…ents.txt-when-run-with---disable-pip
Nope, I've just been delayed in reviews, sorry 😅. I'll do another pass on this today. (Thank you very much for keeping this PR alive and conflict-free!) |
|
@woodruffw I updated the changelog, feel free to change it if it's not clear enough |
woodruffw
requested changes
Aug 26, 2024
woodruffw
reviewed
Aug 26, 2024
…ents.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
…uirements.txt-when-run-with---disable-pip
woodruffw
reviewed
Oct 21, 2024
…ents.txt-when-run-with---disable-pip
…ents.txt-when-run-with---disable-pip
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
approved these changes
Oct 22, 2024
|
Thanks for your hard work and patience here @mathbou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I run in the same problem described in #662. To avoid this, I propose a finer check for duplicates based on both name and specifier.
As stated in the issue, when the
--disable-pipflag is used, we could consider that a full requirement resolution has been made. Knowing that, as long as specifiers matches, having duplicates is not a problem. If they don't match, we raise an error like before.On the side, I also add a small fix for stdout/stderr reading in
pip_audit/_subprocess.py. I don't know if it's specific to windows, but the fact that a size was specified, I had the process hanging indefinitely.