Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases to output. #721

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Add aliases to output. #721

merged 5 commits into from
Jan 10, 2024

Conversation

pboulos
Copy link
Contributor

@pboulos pboulos commented Jan 7, 2024

Implementation for #235.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One tiny nitpick, and needs deconflict.

pip_audit/_format/columns.py Outdated Show resolved Hide resolved
pip_audit/_cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @pboulos, just had a question about the behaviour of the --aliases flag with the JSON format.

pip_audit/_cli.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pip_audit/_cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pboulos.

@tetsuo-cpp tetsuo-cpp merged commit 11d2786 into pypa:main Jan 10, 2024
7 checks passed
@woodruffw woodruffw mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants