-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatible version specifier incorrectly strip trailing '0' #493
Conversation
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Pradyun Gedam <[email protected]>
Not sure if we need a test case for the specific problem raised originally in pypa/pip#9613—make sure |
let's add one |
Hi all, can this now be merged? |
It is the holidays so I don't know who's available to do a thorough review (I just quickly glanced at the code). At worst we can look at merging it in the new year. |
Co-authored-by: Brett Cannon <[email protected]>
Thanks, sound fine to me |
Code LGTM, but this isn't my area of expertise. I'll give @pradyunsg a week to review, otherwise I will just lean on the review from @uranusjr . Feel free to @ me on this PR, @kasium in a week to get this merged. |
Thanks @kasium for the PR, and thanks @brettcannon for the mention! :) |
When comparing two specifier with the compatible operator, tailing zeros are incorrectly stripped.
Closes #421